-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] website_sale_product_minimal_price: Migration to 17.0 #938
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] website_sale_product_minimal_price: Migration to 17.0 #938
Conversation
@gurneyalex Hello! Could you check this module migration and merge if all okay? |
@pedrobaeza , please, check this MR and help to merge it. |
/ocabot migration website_sale_product_minimal_price Please follow migration guide splitting the changes into 2 commits: one for the pre-commit auto-stuff, and the other for the migration itself. Reference: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 |
4373ad2
to
615949a
Compare
@pedrobaeza, fixed, the changes was splitted into 2 commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dive deep into the migration, which seems to be a big refactor. Some formal comments thou
website_sale_product_minimal_price/tests/test_product_with_no_prices.py
Outdated
Show resolved
Hide resolved
website_sale_product_minimal_price/tests/test_website_sale_product_minimal_price.py
Outdated
Show resolved
Hide resolved
d3d21b6
to
2a3f818
Compare
* [11.0][NEW] website_sale_product_minimal_price: New module * [11.0][IMP] website_sale_product_minimal_price: Order by minimal variant price (from pricelists or extra variant price) [UPD] Update website_sale_product_minimal_price.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_minimal_price/ [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/
… avoid the inheritance problems
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/nl/
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/es/
Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/ca/
Ensure we use a consistant currency TT28906
…s of 12.0 Forward port adapting the minimal price computing to the new way added on version 13.0. With the changes added the price takes care on the website selected pricelist and it's added the grid of price scale for each product.variant. TT24175
…list item When the product has a sales price = 0, his variants has no extra price and a pricelist depends on other pricelists to compute the prices, the algorithm takes a random variant. Doing this changes we take care all pricelists that depends on the main to compute the prices asociated to the product. This changes are forward ported and addapted to 13.0 version from this commit OCA@fe99a35#diff-d3f954ac4904966e21fd42f7b88212a43b229ad5c025afc848408a4127215ebe
Currently translated at 100.0% (6 of 6 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_minimal_price/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_minimal_price/
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_minimal_price/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-16.0/e-commerce-16.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_product_minimal_price/
Currently translated at 100.0% (3 of 3 strings) Translation: e-commerce-16.0/e-commerce-16.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-16-0/e-commerce-16-0-website_sale_product_minimal_price/it/
2a3f818
to
1dc106b
Compare
1dc106b
to
50de695
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.